[Merge] lp:~thomas-voss/media-hub/decouple-player-skeleton-and-implementation into lp:media-hub
Thomas Voß
thomas.voss at canonical.com
Mon Dec 1 16:16:35 UTC 2014
Thomas Voß has proposed merging lp:~thomas-voss/media-hub/decouple-player-skeleton-and-implementation into lp:media-hub with lp:~thomas-voss/media-hub/decouple-service-skeleton-and-implementation as a prerequisite.
Commit message:
Decouple PlayerSkeleton and PlayerImplementation by making PlayerImplementation being
able to inherit from arbitrary base classes, as long as they provide the set of properties and signals defined by media::Player.
Adjust the implementation to account for decoupling.
Requested reviews:
Ubuntu Phablet Team (phablet-team)
For more details, see:
https://code.launchpad.net/~thomas-voss/media-hub/decouple-player-skeleton-and-implementation/+merge/243303
Decouple PlayerSkeleton and PlayerImplementation by making PlayerImplementation being
able to inherit from arbitrary base classes, as long as they provide the set of properties and signals defined by media::Player.
Adjust the implementation to account for decoupling.
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~thomas-voss/media-hub/decouple-player-skeleton-and-implementation into lp:media-hub.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 18284 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20141201/cfa436b9/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list