[Merge] lp:~abreu-alexandre/webbrowser-app/user-agent-override-fails into lp:webbrowser-app

Alexandre Abreu alexandre.abreu at canonical.com
Thu Dec 4 16:04:44 UTC 2014


> 126     +        self.assertThat(self.get_webcontainer_window().title,
> 127     +                        Eventually(Contains(result)))
> 
> Can’t you test the webview’s title, instead of the window’s title? E.g.
> something like that:
> 
>     webview = self.get_oxide_webview()
>     self.assertThat(webview.title, Eventually(Equals(result)))

Agree, makes it more to the point and testing what is supposed to be tested
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/user-agent-override-fails/+merge/243286
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list