[Merge] lp:~canonical-platform-qa/webbrowser-app/autopilot-webbrowser_cpo into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Mon Dec 15 16:23:56 UTC 2014
That looks mostly good to me. One question though about the implementation of validate_dbus_object(…): when running the autopilot tests locally from my branch, the name property equals b'/webbrowser-app', with a leading forward slash. Is the check in your code (without the forward slash) correct?
And regarding the comment that the second check is probably overkill: if it’s overkill, why leave it there? Is there any chance that path == b'webbrowser-app' but the applicationName is not "webbrowser-app" ?
--
https://code.launchpad.net/~canonical-platform-qa/webbrowser-app/autopilot-webbrowser_cpo/+merge/244659
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~canonical-platform-qa/webbrowser-app/autopilot-webbrowser_cpo into lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list