[Merge] lp:~ssweeny/friends/fix-lp1258657 into lp:friends
Scott Sweeny
scott.sweeny at canonical.com
Mon Feb 17 04:00:38 UTC 2014
Scott Sweeny has proposed merging lp:~ssweeny/friends/fix-lp1258657 into lp:friends.
Requested reviews:
Super Friends (super-friends)
Related bugs:
Bug #1258657 in friends (Ubuntu): "flickr plugin error: ValueError: GET/HEAD requests should not include body."
https://bugs.launchpad.net/ubuntu/+source/friends/+bug/1258657
For more details, see:
https://code.launchpad.net/~ssweeny/friends/fix-lp1258657/+merge/206650
Flickr: Fix oauth signing for a GET request.
According to [1] the base string for the OAuth signature must include all of the parameters, but oauthlib won't sign a GET request that includes a body. Instead pass the parameters as part of the URL.
[1] https://secure.flickr.com/services/api/auth.oauth.html
--
https://code.launchpad.net/~ssweeny/friends/fix-lp1258657/+merge/206650
Your team Super Friends is requested to review the proposed merge of lp:~ssweeny/friends/fix-lp1258657 into lp:friends.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 695 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140217/7dc6f912/attachment.diff>
More information about the Ubuntu-reviews
mailing list