[Merge] lp:~kai-mast/friends-app/images into lp:friends-app
Kai Mast
mail at kai-mast.de
Thu Jan 30 19:44:18 UTC 2014
Kai Mast has proposed merging lp:~kai-mast/friends-app/images into lp:friends-app.
Requested reviews:
Super Friends (super-friends)
Related bugs:
Bug #1169679 in friends-app (Ubuntu): "Make images first-class citizens."
https://bugs.launchpad.net/ubuntu/+source/friends-app/+bug/1169679
For more details, see:
https://code.launchpad.net/~kai-mast/friends-app/images/+merge/204061
Branch looks fine to me now. I introduced:
* Settings (and storage via U1DB)
* Inlining images
* Some convergence for broad layouts
However, it still produces a warning about a binding loop that I cannot resolve but it doesn't cause any problems.
--
https://code.launchpad.net/~kai-mast/friends-app/images/+merge/204061
Your team Super Friends is requested to review the proposed merge of lp:~kai-mast/friends-app/images into lp:friends-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 37391 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140130/3af3bf94/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list