[Merge] lp:~fboucault/camera-app/hook_up_hdr into lp:camera-app

Olivier Tilloy olivier.tilloy at canonical.com
Fri Jul 11 10:12:08 UTC 2014


Code changes look good to me, I haven’t tested them functionally though, as packages for qtubuntu-camera failed to build in silo 12.

One minor question:

10	+// Definition of this enum value is duplicated in qtubuntu-camera
11	+static const QCameraExposure::ExposureMode ExposureHdr = static_cast<QCameraExposure::ExposureMode>(QCameraExposure::ExposureModeVendor + 1);


Couldn’t we patch QtMultimedia to add this value to the QCameraExposure::ExposureMode enum? Or, if this doesn’t make sense, doesn’t qtubuntu-camera expose public headers that we could refer to instead of duplicating the definition of this custom value (which eventually will bite us when they get out of sync)?
-- 
https://code.launchpad.net/~fboucault/camera-app/hook_up_hdr/+merge/226219
Your team Ubuntu Phablet Team is subscribed to branch lp:camera-app.



More information about the Ubuntu-reviews mailing list