[Merge] lp:~mandel/ubuntu-download-manager/content-disposition into lp:ubuntu-download-manager

Manuel de la Peña manuel.delapena at canonical.com
Wed Jul 30 09:24:30 UTC 2014


Manuel de la Peña has proposed merging lp:~mandel/ubuntu-download-manager/content-disposition into lp:ubuntu-download-manager.

Commit message:
Parse the content disposition header for the file name to use.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1205355 in ubuntu-download-manager: "Content-Disposition is not used to get the file name"
  https://bugs.launchpad.net/ubuntu-download-manager/+bug/1205355

For more details, see:
https://code.launchpad.net/~mandel/ubuntu-download-manager/content-disposition/+merge/228804

The solution is not perfect but it will cover most of the cases (if not all) for the content-disposition header. The implementation is very similar to the one found in webkit.
-- 
https://code.launchpad.net/~mandel/ubuntu-download-manager/content-disposition/+merge/228804
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mandel/ubuntu-download-manager/content-disposition into lp:ubuntu-download-manager.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 10423 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140730/4db10a11/attachment.diff>


More information about the Ubuntu-reviews mailing list