[Merge] lp:~kaijanmaki/dbus-cpp/read-only-properties-changed-fix into lp:dbus-cpp

Antti Kaijanmäki antti.kaijanmaki at canonical.com
Tue Jun 3 08:29:28 UTC 2014


The test-case passes after making the change, but now that the possible exceptions are not silently discarded I'm seeing this during the test run:
[ RUN      ] Service.AddingServiceAndObjectAndCallingIntoItSucceeds
void core::dbus::Property<T>::handle_changed(const core::dbus::types::Variant&) [with PropertyType = test::Service::Properties::ReadOnly]: Mismatch between expected and actual type reported by iterator: 
         Expected: uint32
         Actual: invalid
void core::dbus::Property<T>::handle_changed(const core::dbus::types::Variant&) [with PropertyType = test::Service::Properties::ReadOnly]: Mismatch between expected and actual type reported by iterator: 
         Expected: uint32
         Actual: invalid

That must be because of the fact that the Variant is consumed by the first caller of Variant::as<>().

But to emphasize: The test passes and everything seems to work properly even though we now get that exception caught.
-- 
https://code.launchpad.net/~kaijanmaki/dbus-cpp/read-only-properties-changed-fix/+merge/221839
Your team Ubuntu Phablet Team is subscribed to branch lp:dbus-cpp.



More information about the Ubuntu-reviews mailing list