[Merge] lp:~achiang/ubuntu-seeds/ubuntu-touch.utopic into lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.utopic

[Colin Watson]

[I can't speak for the package-level details; this review is just
regarding the general seed structure.]

On Fri, Jun 27, 2014 at 01:01:21AM -0000, Alex Chiang wrote:
> I also did not expect that I would have to manually add
> ubuntu-touch-core and ubuntu-touch-android as explicit Depends in
> debian/control...

Historically, we intentionally haven't made the metapackages depend on
each other, because it makes it excessively painful when you want to
vary from (say) ubuntu-standard but you're quite happy with the contents
of ubuntu-desktop.  We usually deal with ensuring that we have all the
right metapackages in livecd-rootfs or similar instead.

However, in the particular case of touch, it's probably OK to do this
using explicit Depends.

> But I think germinate tries to be smart about overlapping packages or something, and that is why the debdiff is huge:
> 
> http://pastebin.ubuntu.com/7708769/

This all seems as expected.  If you have packages in an inner seed (or
its dependency-expansion), then they don't also need to show up in the
expansion of an outer seed.  That's the whole point of seed inheritance.

> In any case, feedback is appreciated.

Please let's not have a seed called "core", anywhere.  Vast confusion
with the existing core package set will result.  Call it "touch-core",
perhaps.  Ditto android -> touch-android.  You're explicitly specifying
the task and metapackage names, so changing the seed names will be
harmless.

> -touch: minimal sdk-libs
> -desktop: minimal sdk-libs
> +android: minimal sdk-libs
> +core: minimal sdk-libs
> +touch: minimal sdk-libs android core
> +desktop: minimal sdk-libs core

There is no need to repeat the transitive inheritance, so this is
sufficient:

  touch: touch-android touch-core
  desktop: touch-core

Is it possible that touch-android should inherit from touch-core?  If
you're never going to use touch-android without touch-core, then that
would save a lot of duplication of entries in Task fields.

> +Task-Per-Derivative: 1
> +Task-Section: user
> +Task-Description: Ubuntu touch android
> +Task-Extended-Description: This task provides the Android-to-Ubuntu bridge
> +Task-Key: ubuntu-touch-android
> +Task-Name: ubuntu-touch-android
> +Task-Metapackage: ubuntu-touch-android

I'm not entirely sure why we bother to create a task for the current
touch seed at all; as far as I can see it isn't used, so it's just bloat
in the Packages file for no reason.  However, maybe I've missed
something, so it's probably OK to add tasks for these.  I might go round
and clean this up later.

-- 
https://code.launchpad.net/~achiang/ubuntu-seeds/ubuntu-touch.utopic/+merge/224738
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~achiang/ubuntu-seeds/ubuntu-touch.utopic into lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.utopic.