[Merge] lp:~stgraber/ubuntu/trusty/systemd/logind-cgmanager into lp:ubuntu/systemd

Martin Pitt martin.pitt at ubuntu.com
Thu Mar 20 06:24:06 UTC 2014


Review: Approve

> Branch updated to add the missing free().

Thanks. As I said, using _cleanup_free is much simpler and less error prone for cases like this, but it looks correct to me now.

LGTM now.

> Is there a bug report for this? I suppose this needs an FFE and proper testing at this point of the release cycle.

This is still an open question. When you upload it would be nice to refer to that bug.

Thanks!
-- 
https://code.launchpad.net/~stgraber/ubuntu/trusty/systemd/logind-cgmanager/+merge/211649
Your team Ubuntu branches is requested to review the proposed merge of lp:~stgraber/ubuntu/trusty/systemd/logind-cgmanager into lp:ubuntu/systemd.



More information about the Ubuntu-reviews mailing list