[Merge] lp:~thomas-voss/trust-store/fix-1387734 into lp:trust-store
Thomas Voß
thomas.voss at canonical.com
Mon Nov 17 12:08:02 UTC 2014
> This change looks good to me, thanks.
>
> I do wonder though how long old answers will be cached in the trust store; I
> initially wondered if adding an O(N * log(N)) sorting step to what used to be
> an O(1) query might do to the performance over the long run, but it might make
> more sense to ask why we need to keep older responses around when newer
> responses have been added to the trust store.
>
I think keeping them around to have a history of trust available for forensics is a nice feature to have. I would be hesitant to remove it, and instead would propose a convenience function as described below.
> What will reclaim this storage and how often?
Right now: nothing and never. I think we should introduce a function add_and_purge(const Request&), which takes care of removing all old entries.
--
https://code.launchpad.net/~thomas-voss/trust-store/fix-1387734/+merge/241790
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~thomas-voss/trust-store/fix-1387734 into lp:trust-store.
More information about the Ubuntu-reviews
mailing list