[Merge] lp:~ted/ubuntu-touch-session/indicator-sound-override-v2 into lp:ubuntu-touch-session
Charles Kerr
charles.kerr at canonical.com
Mon Nov 17 21:32:36 UTC 2014
Ted, I agree with the basic idea but the implementation looks pretty aggressive compared to the other override & conf scripts -- waking 10x per second with no timeout condition to end the loop.
On the one hand, if [ -S /run/user/`id -u`/pulse/dbus-socket ] fails then wakeups are not the most important problem we've got. OTOH we should at least have a timeout to break out of the while loop.
--
https://code.launchpad.net/~ted/ubuntu-touch-session/indicator-sound-override-v2/+merge/241640
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ted/ubuntu-touch-session/indicator-sound-override-v2 into lp:ubuntu-touch-session.
More information about the Ubuntu-reviews
mailing list