[Merge] lp:~abreu-alexandre/webbrowser-app/add-uninstall-click-hook-to-webapps into lp:webbrowser-app

Alberto Mardegan alberto.mardegan at canonical.com
Tue Nov 18 14:39:07 UTC 2014


Review: Needs Fixing

I didn't review it thoroughly, but I'd like to suggest two changes:

1) Of course, this is about the style :-) Make it consistent, in some places you are using "type& var", in some others "type &var".

2) I think that the OptionalData class (and the Fallible template) can be removed and the code simplified a bit. The Data() default constructor already does the right thing (setting the optional fields to "false") and it doesn't look like you really need to distinguish the case when the hook file is absent or if it's present and the keys are set to false.
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/add-uninstall-click-hook-to-webapps/+merge/241584
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list