[Merge] lp:~abreu-alexandre/webbrowser-app/local-app into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Nov 19 10:16:34 UTC 2014


Review: Needs Fixing

Please revert the changes to browserapplication.[h|cpp], they don’t belong there as they are specific to the webapp container. If you really need to go through all those hoops for testing, then mark the BrowserApplication::urls() method virtual, and override it in WebappContainer.
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/local-app/+merge/240505
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list