[Merge] lp:~phablet-team/ofono/vivid-update-1 into lp:~phablet-team/ofono/ubuntu

Tony Espy espy at canonical.com
Thu Nov 20 00:10:34 UTC 2014


Tony Espy has proposed merging lp:~phablet-team/ofono/vivid-update-1 into lp:~phablet-team/ofono/ubuntu.

Commit message:
  * grilreply.c, parcel.c, rilmodem: merge data and voice reg parsing
    This change splits the orginal parsing code for data and voice
    registration replies, cleaning up some of original parsing code
    which wasn't very elegant.
  * Makefile.am, rilmodem, src/sim*.*, include/sim.h,
    plugins/mtk.c, ril.c: enable SIM phonebook import support
  * rilmodem/sim.c, plugins/mtk.c, ril.c: fix SIM interface signals (LP: #1376250)
  * plugins/mtk.c: fix krillin slow socket disconnection (LP: #1388030)
  * Makefile.am, doc/mtk-settings-api.txt, mtkmodem,
    plugins/mtk.c, test, unit: support krillin 3g slot switch (LP: #1373388)


Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1373388 in ofono (Ubuntu): "Allow user to change SIM slot technologies ( ex. 2G vs. 3G )"
  https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1373388
  Bug #1376250 in Network Menu: "i-network says "Unknown" or "No SIM" on N4 (mako), can't unlock the SIM"
  https://bugs.launchpad.net/indicator-network/+bug/1376250
  Bug #1388030 in ofono (Ubuntu): "[TOPBLOCKER] [krillin] Failure to unset flight mode"
  https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1388030

For more details, see:
https://code.launchpad.net/~phablet-team/ofono/vivid-update-1/+merge/242287

This change brings vivid up to the latest HEAD of the rilmodem git tree.  Changes include:

 * Merge of RIL data and voice reg parsing code.  This change splits the orginal parsing code for data and voice registration replies, cleaning up some of original parsing code which wasn't very elegant.

 * enable SIM phonebook import support

 * fix SIM interface signals (LP: #1376250)

 * fix krillin slow socket disconnection (LP: #1388030)

 * support krillin 3g slot switch (LP: #1373388)

-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/ofono/vivid-update-1 into lp:~phablet-team/ofono/ubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 108192 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20141120/836a25cf/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list