[Merge] lp:~thomas-voss/media-hub/introduce-client-death-observer-interface into lp:media-hub

Thomas Voß thomas.voss at canonical.com
Wed Nov 26 09:23:34 UTC 2014


Thomas Voß has proposed merging lp:~thomas-voss/media-hub/introduce-client-death-observer-interface into lp:media-hub with lp:~thomas-voss/media-hub/make-video-size-a-proper-type as a prerequisite.

Commit message:
Add an interface media::ClientDeathObserver that abstracts away receiving key-based death notifications for clients associated to media::Player instances server-side
Provide an implementation media::HybrisClientDeathObserver that relies on hybris and ultimately on Android's onBinderDied to receive death notifications.
Adjust media::PlayerStub and media::PlayerImplementation to account for the new interface.
Adjust the CMake setup for tests to link media-hub-service instead of recompiling large parts of the implementation classes.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~thomas-voss/media-hub/introduce-client-death-observer-interface/+merge/242884

Add an interface media::ClientDeathObserver that abstracts away receiving key-based death notifications for clients associated to media::Player instances server-side
Provide an implementation media::HybrisClientDeathObserver that relies on hybris and ultimately on Android's onBinderDied to receive death notifications.
Adjust media::PlayerStub and media::PlayerImplementation to account for the new interface.
Adjust the CMake setup for tests to link media-hub-service instead of recompiling large parts of the implementation classes.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~thomas-voss/media-hub/introduce-client-death-observer-interface into lp:media-hub.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 13476 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20141126/d8593924/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list