[Merge] lp:~thomas-voss/media-hub/introduce-power-controller-interface into lp:media-hub

[Thomas Voß]

Thomas Voß has proposed merging lp:~thomas-voss/media-hub/introduce-power-controller-interface into lp:media-hub with lp:~thomas-voss/media-hub/move-playbin-implementation-to-cpp-file as a prerequisite.

Commit message:
Introduce a common class media::helper::ExternalHelpers that provides a convenient way to:

  * Access the system and session bus instances.
  * Prepares for integration testing scenarios as we can switch to private testing bus instances.
  * Dispatch execution of tasks to worker threads.
  * Requires only one external worker thread transparently shared by implementations requiring access to the respective bus instances.

Introduce interfaces media::power::StateController and media::power::StateController::Lock for acquiring and releasing locks on power-relevant system components, mainly:

  * The display subsystem.
  * The overall system power state.

Provide two implementations talking to the com.canonical.Unity.Screen and com.canonical.powerd
that implement media::power::StateController and media::power::StateController::Lock.

Adjust existing implementation to leverage power::StateController{::Lock}.
Adjust server setup to:

  * hand down an instance of media::helper::ExternalServices to media::ServiceImplementation.
  * spin up two threads running the actual service and the external service helper in an exception-safe way.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~thomas-voss/media-hub/introduce-power-controller-interface/+merge/242905

Introduce a common class media::helper::ExternalHelpers that provides a convenient way to:

  * Access the system and session bus instances.
  * Prepares for integration testing scenarios as we can switch to private testing bus instances.
  * Dispatch execution of tasks to worker threads.
  * Requires only one external worker thread transparently shared by implementations requiring access to the respective bus instances.

Introduce interfaces media::power::StateController and media::power::StateController::Lock for acquiring and releasing locks on power-relevant system components, mainly:

  * The display subsystem.
  * The overall system power state.

Provide two implementations talking to the com.canonical.Unity.Screen and com.canonical.powerd
that implement media::power::StateController and media::power::StateController::Lock.

Adjust existing implementation to leverage power::StateController{::Lock}.
Adjust server setup to:

  * hand down an instance of media::helper::ExternalServices to media::ServiceImplementation.
  * spin up two threads running the actual service and the external service helper in an exception-safe way.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~thomas-voss/media-hub/introduce-power-controller-interface into lp:media-hub.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 42944 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20141126/f8c840ae/attachment-0001.diff>