[Merge] lp:~abreu-alexandre/webbrowser-app/fix-webapp-properties-ua-override into lp:webbrowser-app

[Alexandre Abreu]

Alexandre Abreu has proposed merging lp:~abreu-alexandre/webbrowser-app/fix-webapp-properties-ua-override into lp:webbrowser-app.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1379497 in webbrowser-app: "[webapp-container] UA Override from an optional webapp-properies.json file is not set"
  https://bugs.launchpad.net/webbrowser-app/+bug/1379497

For more details, see:
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/fix-webapp-properties-ua-override/+merge/237859

A Webapp has the option to either specify a command line option to have a specific UA overriding the default or hgave a local webapp-properties.json file that defines the UA override such as:

{
    "name": "MyWebapp",
    "includes":["http://user-agent.me/*"],
    "domain":"user-agent.me",
    "homepage":"http://user-agent.me/",
    "user-agent-override": "Mozilla/5.0 custom-user-agent-string (unlike AnyOtheBrowser)"
}

This currently does work, or to be more precise works but the url is set before during the init flow, and the UA string is being set after the website was browsed to.

To test it:
-----------

- create a webapp-properties.json file that contains the json above,
- launch the webapp-container with: webapp-container --store-session-cookies --local-webapp-manifest --webapp="TXlXZWJhcHA="
-- make sure that "Mozilla/5.0 custom-user-agent-string (unlike AnyOtheBrowser)" is displayed as the current user agent,
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/fix-webapp-properties-ua-override/+merge/237859
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~abreu-alexandre/webbrowser-app/fix-webapp-properties-ua-override into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1665 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20141009/861c9604/attachment.diff>