[Merge] lp:~phablet-team/gallery-app/popover-position into lp:gallery-app

[Ugo Riboni]

Ugo Riboni has proposed merging lp:~phablet-team/gallery-app/popover-position into lp:gallery-app.

Commit message:
Adjust the popover position for the cover pattern editor.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1374016 in gallery-app: "Wrong position of pop-us on gallery-app "
  https://bugs.launchpad.net/gallery-app/+bug/1374016

For more details, see:
https://code.launchpad.net/~phablet-team/gallery-app/popover-position/+merge/238181

Adjust the popover position for the cover pattern editor.

Please note that this will not center the popover vertically as requested by the bug, only horizontally.
This is a limitation of the popover system at the moment, for popovers that are too wide. According to Tim it might even be an intentional design decision. He's checking with design, but in any case the fix in this branch will automatically center the popoup vertically if it's indeed a bug and it's fixed later in the SDK.

The photo editor popover is already horizontally centered and the code is OK, and will benefit for the fix mentioned above if/when it gets implemented in the SDK.
-- 
https://code.launchpad.net/~phablet-team/gallery-app/popover-position/+merge/238181
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/gallery-app/popover-position into lp:gallery-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1644 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20141013/9bde2c07/attachment.diff>