[Merge] lp:~thomas-voss/qtubuntu-media/fix-races-for-access-to-destroyed-controls into lp:qtubuntu-media

Thomas Voß thomas.voss at canonical.com
Wed Oct 15 09:44:22 UTC 2014


Thomas Voß has proposed merging lp:~thomas-voss/qtubuntu-media/fix-races-for-access-to-destroyed-controls into lp:qtubuntu-media.

Commit message:
Make sure that invocations on probably deleted objects in async callbacks are guarded. 
Condense creation/deletion of controls in one place.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1376467 in qtubuntu-media: "can't playback a second video"
  https://bugs.launchpad.net/qtubuntu-media/+bug/1376467
  Bug #1380736 in Network Menu: "Unlocking sim causes unity8 crash"
  https://bugs.launchpad.net/indicator-network/+bug/1380736

For more details, see:
https://code.launchpad.net/~thomas-voss/qtubuntu-media/fix-races-for-access-to-destroyed-controls/+merge/238404

Make sure that invocations on probably deleted objects in async callbacks are guarded.
Condense creation/deletion of controls in one place.
-- 
https://code.launchpad.net/~thomas-voss/qtubuntu-media/fix-races-for-access-to-destroyed-controls/+merge/238404
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~thomas-voss/qtubuntu-media/fix-races-for-access-to-destroyed-controls into lp:qtubuntu-media.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 6801 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20141015/4a3e63b3/attachment.diff>


More information about the Ubuntu-reviews mailing list