[Merge] lp:~seb128/gallery-app/translations-use-ngettext into lp:gallery-app

Iain Lane iain at orangesquash.org.uk
Wed Oct 15 15:36:47 UTC 2014


If those snippets are identical can they be abstracted?

This is the best I could think of but I'm not confident that this solves all of the edge cases. I think the only 100% safe way would be to find some text that doesn't require combination (the Samsung gallery app says "Delete n items", and the Google photo app says something about deleting being permanent but doesn't show a count on the confirmation), since ngettext only supports translations with one variable at a time.

If nobody can think of a flaw in this then it's probably good enough.
-- 
https://code.launchpad.net/~seb128/gallery-app/translations-use-ngettext/+merge/238456
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~seb128/gallery-app/translations-use-ngettext into lp:gallery-app.



More information about the Ubuntu-reviews mailing list