[Merge] lp:~rpadovani/webbrowser-app/settings-page into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Apr 7 17:09:45 UTC 2015


> BTW, we should take a look to the function looksLikeAUrl(). It checks if
> tld.length is < 5 (.match(/\.[a-zA-Z]{2,4}$/))
> Now TLD could be very long[0], so we should remove that restriction (also if
> they aren't used so much at the moment, the only one I know is com.google)

Good point. Can you file a bug report to track the issue separately?
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/settings-page/+merge/253975
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list