[Merge] lp:~abreu-alexandre/webbrowser-app/remove-qtwebkit-deps into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Wed Apr 8 08:25:43 UTC 2015
Review: Needs Fixing
972 - topMargin: (webapp.oxide || webapp.chromeless) ? 0 : chromeLoader.item.height
973 + topMargin: webapp.chromeless ? 0 : chromeLoader.item.height
The above change is incorrect, the top margin should now always be 0. So the line can be removed altogether.
The ChromeController instance doesn’t need to be inside a Loader any longer, as it’s always instantiated anyway.
--
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/remove-qtwebkit-deps/+merge/254291
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list