[Merge] lp:~ken-vandine/webbrowser-app/contextual_sharelink into lp:webbrowser-app

Ken VanDine ken.vandine at canonical.com
Thu Apr 9 14:37:56 UTC 2015


> That looks good, thanks for implementing this (the ShareLink action seemed to
> be unused, I guess it’s an oversight).
> 
> The same code is used for the share action in the drawer. Could you please
> factor it out in a shareLink(url, title) function (for instance under the
> 'internal' QtObject)?

Sure, I'll take a look at that.
-- 
https://code.launchpad.net/~ken-vandine/webbrowser-app/contextual_sharelink/+merge/255207
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ken-vandine/webbrowser-app/contextual_sharelink into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list