[Merge] lp:~philpem/ubuntu/utopic/ptouch-driver/ptouch-driver-fixup into lp:ubuntu/utopic/ptouch-driver

Till Kamppeter till.kamppeter at gmail.com
Fri Apr 10 22:00:44 UTC 2015


Generally it looks OK, but we need to consider the following:

1. GIT repositories of a package (or any changes on it) should be done always with the quilt patches not applied and without .pc directory, to avoid redundancies and to make it easy to modify a patch without needing to modify a whole bunch of other files along with it.

2. Such a lot of changes should go upstream and not kept as distro patches to the eternity. If the upstream maintainer has disappeared, I suggest that you overtake upstream maintainership.
-- 
https://code.launchpad.net/~philpem/ubuntu/utopic/ptouch-driver/ptouch-driver-fixup/+merge/255895
Your team Ubuntu Development Team is requested to review the proposed merge of lp:~philpem/ubuntu/utopic/ptouch-driver/ptouch-driver-fixup into lp:ubuntu/utopic/ptouch-driver.



More information about the Ubuntu-reviews mailing list