[Merge] lp:~phablet-team/ofono/lp1435328 into lp:~phablet-team/ofono/utopic-rtm

Tony Espy espy at canonical.com
Mon Apr 13 23:44:26 UTC 2015


Tony Espy has proposed merging lp:~phablet-team/ofono/lp1435328 into lp:~phablet-team/ofono/utopic-rtm.

Commit message:
  [ Tony Espy ]
  * rilmodem/gprs-context.c: if data call list is empty, disconnect (LP: #1435328)
    If a DATA_CALL_LIST_CHANGED is received with an
    empty call list, and the gprs-context is not IDLE,
    disconnect the active data call.


Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1435328 in Canonical System Image: "Leaving Wifi does not connect to mobile carrier data (GSM)"
  https://bugs.launchpad.net/canonical-devices-system-image/+bug/1435328

For more details, see:
https://code.launchpad.net/~phablet-team/ofono/lp1435328/+merge/256059

This change fixes a bug in rilmodem's gprs-context code where a DATA_CALL_LIST_CHANGED message with no calls in it causes the code to zero out the local private data, but doesn't inform the core ofono gprs atom that the context has disconnected.

This should fix bug #1435328, and possibly bug #1436427 and other bugs having to do with mobile data connections dropping and not being properly restored.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/ofono/lp1435328 into lp:~phablet-team/ofono/utopic-rtm.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1918 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150413/7a13858d/attachment.diff>


More information about the Ubuntu-reviews mailing list