[Merge] lp:~uriboni/webbrowser-app/bookmarks-in-suggestions into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Thu Apr 16 17:38:03 UTC 2015
615 + if (foundTerms.count() == m_terms.count()) {
I can see one possible corner case where this will fail: if m_terms contains doublons (e.g. if for whatever reason I typed in the address bar "ubuntu ubuntu"). This is arguably not a very important use case, but I think it’s easy enough to fix regardless, by comparing to QSet<QString>::fromList(m_terms).count() (and adding a unit test for it).
--
https://code.launchpad.net/~uriboni/webbrowser-app/bookmarks-in-suggestions/+merge/256459
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list