[Merge] lp:~unity-team/qtubuntu/DPR into lp:qtubuntu
Daniel d'Andrada
daniel.dandrada at canonical.com
Wed Apr 29 13:51:29 UTC 2015
Review: Needs Fixing
In src/ubuntumirclient/window.cpp
"""
// Window manager can give us a final size different from what we asked for
// so let's check what we ended up getting
{
MirSurfaceParameters parameters;
mir_surface_get_parameters(d->surface, ¶meters);
geometry.setWidth(divideAndRoundUp(parameters.width, devicePixelRatio()));
geometry.setHeight(divideAndRoundUp(parameters.height, devicePixelRatio()));
DLOG("[ubuntumirclient QPA] created surface has pixel size (%d, %d) and device-pixel size (%d, %d)",
parameters.width, parameters.height, geometry.width(), geometry.height());
}
// Assume that the buffer size matches the surface size at creation time
d->bufferSize = geometry.size();
"""
Here bufferSize will be initialized with a scaled size, but it should have the real size.
So bufferSize initialization should probably moved above the line "// Window manager can give us a final size different[...]".
--
https://code.launchpad.net/~unity-team/qtubuntu/DPR/+merge/257515
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.
More information about the Ubuntu-reviews
mailing list