[Merge] lp:~artmello/webbrowser-app/webbrowser-app-fix_1484175 into lp:webbrowser-app
Arthur Mello
arthur.mello at canonical.com
Sat Aug 15 00:48:12 UTC 2015
Taking a look on OptionSelector implementation[0] it seems that the currentlyExpanded property is set before the animation of expanding/collapsing finishes. So, in fact, checking for it is not a good way to guarantee that the button in the BookmarkOption dialog is on its final position. Following the documentation[1], it could be possible to check the signal expansionCompleted that should be emitted after animation ended. But it seems it is only emitted after expansion is completed. Need to check with SDK team if that is a issue in documentation or a bug. With that I am changing test to verify that the height has it final value after collapsing OptionSelector.
[0] http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk/view/head:/src/Ubuntu/Components/1.3/OptionSelector.qml#L230
[1] https://developer.ubuntu.com/api/apps/qml/sdk-15.04/Ubuntu.Components.OptionSelector/
--
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-fix_1484175/+merge/268153
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~artmello/webbrowser-app/webbrowser-app-fix_1484175 into lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list