[Merge] lp:~osomon/webbrowser-app/userAgentOverrides into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Aug 17 14:28:44 UTC 2015


> temp.overrides being left unchecked type wise, could it cause an issue
> with userAgentOverrides if it is not of the expected type (or null) ?

It won’t cause issues because strict checks are implemented in oxide. I verified that by messing with the contents of ua-overrides-desktop.js on my desktop machine.
If I set overrides to be a string instead of an array, I get the following error message:

  UbuntuWebContext.qml:88: Error: Cannot assign QString to QVariantList

If I keep overrides an array but mess with its contents, I get the following error message from oxide:

  OxideQQuickWebContext::userAgentOverride: Each entry must be a list of size 2, with the first item being a valid regular expression for URL matching and the second item being the user agent string

-- 
https://code.launchpad.net/~osomon/webbrowser-app/userAgentOverrides/+merge/268210
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list