[Merge] lp:~uriboni/webbrowser-app/search-history into lp:webbrowser-app

Ugo Riboni ugo.riboni at canonical.com
Thu Aug 20 17:22:55 UTC 2015


The proposal to merge lp:~uriboni/webbrowser-app/search-history into lp:webbrowser-app has been updated.

Description changed to:

Implement search within the history view (only from the widescreen version)

NOTE to reviewer: the original author of the HistoryViewWide.qml file seems to have used a mix of different indentation styles and also in some cases left blank lines with spaces. I had my editor setup to automatically remove these and enforce the standard QML style, and noticed this too late. I could go back and revert these changes but I would rather not to.

Reviewing this MR commmit by commit is actually a much better way to understand it (especially the changes in the models) and should prevent the confusion generated by style-only changes mixed with code changes.

For more details, see:
https://code.launchpad.net/~uriboni/webbrowser-app/search-history/+merge/268610
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~uriboni/webbrowser-app/search-history into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list