[Merge] lp:~jamesh/gallery-app/thumbnail-mtime into lp:gallery-app
James Henstridge
james.henstridge at canonical.com
Tue Dec 1 08:04:15 UTC 2015
Sorry for not getting back to you on this. I did manage to reproduce your finding, but it wasn't consistent: sometimes it would advance to the next photo and other times it wasn't. So that sounds like a race condition.
I tried instrumenting the QML side code and don't see the view index being changed from that side.
At this point, my guess is that you're seeing a pre-existing race condition. I see that the code is using QFileSystemWatcher to track file system changes, and this feeds into the QAbstractListModel. If an item is being removed then added, this could presumably cause the view index to move forward (i.e. row 2 deleted, causing view to point at new row 2. New row inserted between rows 1 and 2 causes index to move forward to 3).
My patch doesn't even touch this code, so I don't know how it could be responsible for this.
--
https://code.launchpad.net/~jamesh/gallery-app/thumbnail-mtime/+merge/268185
Your team Ubuntu Phablet Team is subscribed to branch lp:gallery-app.
More information about the Ubuntu-reviews
mailing list