[Merge] lp:~abreu-alexandre/webbrowser-app/flexible-lifecycle-click-hook into lp:webbrowser-app

Alexandre Abreu alexandre.abreu at canonical.com
Tue Dec 8 16:40:09 UTC 2015


> Please fix the style of the continuation lines to make it consistent (i.e.,
> don't start a line with a comma).

done,

> There's an inline comment in executeHookDirectives() where I suspect you
> forgot a check.

see the response,

> Also, it's not clear why you changed the test; if you wanted to test one more
> combination, maybe you should rewrite the test to be data-driven (using QFETCH
> and friends)?

updated it was an invalid update
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/flexible-lifecycle-click-hook/+merge/279508
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list