[Merge] lp:~penk/ubuntu-keyboard/qml-candidates into lp:ubuntu-keyboard
Michael Sheldon
michael.sheldon at canonical.com
Mon Feb 2 18:10:53 UTC 2015
The proposal to merge lp:~penk/ubuntu-keyboard/qml-candidates into lp:ubuntu-keyboard has been updated.
Description changed to:
It exposes onQmlCandidateChanged() invokable to QML, then from keyboard layout we can update candidates by something like:
event_handler.onQmlCandidateChanged([a, b, c]);
Are there any related MPs required for this MP to build/function as expected? Please list.
* No
Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
* Yes
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
* Yes
Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-keyboard) on device or emulator?
* Yes
If you changed the UI, was the change specified/approved by design?
* No change
If you changed UI labels, did you update the pot file?
* No change
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
* No change
For more details, see:
https://code.launchpad.net/~penk/ubuntu-keyboard/qml-candidates/+merge/247941
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~penk/ubuntu-keyboard/qml-candidates into lp:ubuntu-keyboard.
More information about the Ubuntu-reviews
mailing list