[Merge] lp:~phablet-team/ofono/arale-enablement into lp:~phablet-team/ofono/ubuntu
Tony Espy
espy at canonical.com
Wed Feb 4 00:07:36 UTC 2015
Tony Espy has proposed merging lp:~phablet-team/ofono/arale-enablement into lp:~phablet-team/ofono/ubuntu.
Commit message:
[ Tony Espy ]
* test/rilmodem/sim: add new SIM test scripts
* test: fix test-call-forwarding script (LP: #1396323)
[ Vicamo Yang ]
* mtkmodem, rilmodem: re-factor naming
This change makes the naming of GRil, mtk_data,
ofono_modem, and ril_data instances consistent.
* rilmodem: fix duplicate APPSTATE* constants
* gril: get rid of duplicate ringbuffer.h (LP: #1408250)
* mtk.c: use RIL_RADIO_POWER request for single slot modems
[ Alfonso Sanchez-Beato ]
* gril, unit, mtk.c: SIM mode and session ID fixes for arale
For MTK modems, DUAL_SIM_MODE requests aren't necessary. Also
add session-id to SIM IO requests for newer MTK modems.
* rilmodem, mtk.c, ril.c: add auto-answer support
This change adds auto-answer support which is triggered
by usage of a special test SIM (MCC/MNC 001/01 or 001/001).
* mtkmodem, unit, mtk.c: support arale firmware switch
This change will cause the correct modem firmware to
be loaded based upon the SIM MCC abd MNC. If new
firmware is loaded, a modem reset is triggered.
* mtkmodem, unit, mtk.c: handle suspend events
RIL_RESUME_REGISTRATION requests are not sent to
MTK modems if suspend events are received.
* gril, include, mbpi, rilmodem, mtkmodem, rilmodem,
gprs, unit, modem, ril.c, mtk.c: LTE updates
This changes detection logic for LTE modems to rilmodem
( via an environment var ) and mtkmodem ( via a modem
query ). If detected, a RIL_INITIAL_ATTACH_APN request
is not sent to the modem during gprs initialization.
Requested reviews:
Ubuntu Phablet Team (phablet-team)
Related bugs:
Bug #1396323 in ofono (Ubuntu): "test-call-forwarding script is broken"
https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1396323
Bug #1408250 in ofono (Ubuntu): "remove duplicated gril/ringbuffer.h"
https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1408250
For more details, see:
https://code.launchpad.net/~phablet-team/ofono/arale-enablement/+merge/248462
This merge includes multiple changes necessry for the enablement of arale. As such, most of the changes affect arale or krillin, however some bug fixes and test scripts are also included.
Changes include:
1. New rilmodem SIM test scripts added
2. Re-factoring of mtkmodem/rilmodem to making variable naming consistent
3. Use std RADIO_POWER request for MTK single slot modems
4. DUAL_SIM_MODE requests aren't necessary for MTK single slot modems
5. Auto-answer support added when special TEST SIMs are detected
6. Support dynamic arale modem firmware switching
7. Send RESUME_REGISTRATION requests to MTK modems when suspend events are received
8. Detect LTE modem capability, and send an INITIAL_ATTACH_APN request during GPRS initialization ( applies to mtkmodem and standard rilmodem )
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/ofono/arale-enablement into lp:~phablet-team/ofono/ubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 159671 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150204/667f67c4/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list