[Merge] lp:~mir-team/qtubuntu/port-to-mirclient into lp:qtubuntu

Gerry Boland gerry.boland at canonical.com
Wed Feb 4 14:49:41 UTC 2015


+ MirEvent const* nativeEvent = ubuntuEvent->nativeEvent;
please use our code style:
const MirEvent *nativeEvent

Bunch of other instances of your more Mir-y style here:

+void UbuntuInput::dispatchInputEvent(QWindow* window, MirInputEvent const* ev)
+void UbuntuInput::dispatchTouchEvent(QWindow* window, MirInputEvent const* ev)
+void UbuntuInput::dispatchKeyEvent(QWindow* window, MirInputEvent const* ev)
+Qt::MouseButton extract_buttons(MirPointerInputEvent const* pev)
+void UbuntuInput::dispatchPointerEvent(QWindow* window, MirInputEvent const* ev)
+void UbuntuInput::dispatchOrientationEvent(QWindow* window, MirOrientationEvent const* event)
-- 
https://code.launchpad.net/~mir-team/qtubuntu/port-to-mirclient/+merge/245164
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list