[Merge] lp:~tiagosh/telepathy-ofono/mms-group-chat into lp:telepathy-ofono

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Wed Feb 4 19:51:04 UTC 2015


Review: Needs Fixing

37	+                if (remoteNumber.isEmpty()) {
38	+                    continue;
39	+                }

If an empty recipient is found, I think it should be removed from the list, because if it is kept, you will end up adding an invalid handle to the initial invitees list.
-- 
https://code.launchpad.net/~tiagosh/telepathy-ofono/mms-group-chat/+merge/243431
Your team Ubuntu Phablet Team is subscribed to branch lp:telepathy-ofono.



More information about the Ubuntu-reviews mailing list