[Merge] lp:~artmello/gallery-app/gallery-app-fix_1416043 into lp:gallery-app

[Bill Filler]

Pretty good, couple of comments:

1) I wouldn't show the check boxes on the date boxes in the Events view as it makes it really hard to read. Instead, in selection mode I'd just make tapping on the date box toggle on/off the selection of all the photos/videos in that Event.

2) I would use a fixed size checkbox so it's the same size for the big and little thumbnails in the Events view. Currently for the big thumbnails it looks quite large and I think it would look better at a fixed size.

3) The toolbar: this applies to camera as well. I think when we are in selection/picker mode and we open an photo, the toolbar should only have the back button and a select action to select the picture. This action will make the photo selected when you return to main select mode. Currently it has a toolbar with all of the actions that the normal photo open has on it, which is weird because it has things like edit, crop, delete, etc. These should all be done from the main selection view I think. The other reason I think it's important to have a select action from the open photo view is because if you open one photo from selection mode and then start swiping, you might find a picture you want to select but there is no way to do this right now. You'd have to return to the main view and try and find that same picture.

4) When we open a picture in select mode, I think the header should be visible by default (it is on camera app), so it's easy to select the photo or go back.

5) This relates to fullscreen mode (so can do in another MR if easier) and comment 4): After playing with this a bit, I think that tapping a photo should open it in fullscreen mode as it does now. However tapping to display the header should leave it in fullscreen mode with the header overlayed (like camera). We should only leave fullscreen mode when returning to one of the main views, Events, Photos, or Albums. Also, we should not reload the photo when toggling the header on/off - currently it seems we are reloading the photo when we show the header.
-- 
https://code.launchpad.net/~artmello/gallery-app/gallery-app-fix_1416043/+merge/248590
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~artmello/gallery-app/gallery-app-fix_1416043 into lp:gallery-app.