[Merge] lp:~mandel/ciborium/remount-drives-take-2 into lp:ciborium

Manuel de la Peña manuel.delapena at canonical.com
Thu Feb 5 15:57:28 UTC 2015


Manuel de la Peña has proposed merging lp:~mandel/ciborium/remount-drives-take-2 into lp:ciborium.

Commit message:
Ensure that we remount the drives after we format them. Remove deadlocks.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~mandel/ciborium/remount-drives-take-2/+merge/248783

The follwing MR does a number of changes to ensure that we can handle the dbus events in an asycn way to work around this go dbus bug https://bugs.launchpad.net/go-dbus/+bug/1416352

* In the code now jobs are handled by a job manager that keeps track of them to later fwd to a channel with their state. 
* The udisks code listens to the diff channels and reacts according to them:
    * Additions: new interfaces are added and therefore a new drive is present.
    * Removals: Interfaces are done. A drive has gone.
    * Jobs: the diff jons performed on udisk that do not represent drives (Erase, Format)
* Udisks tracks the diff formatted drives and will mount them again when the Filesystem interface is re-added.
* Tests have been added to the changes.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mandel/ciborium/remount-drives-take-2 into lp:ciborium.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 35331 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150205/bd174bc7/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list