[Merge] lp:~artmello/gallery-app/gallery-app-fix_1416043 into lp:gallery-app
Bill Filler
bill.filler at canonical.com
Fri Feb 6 17:06:44 UTC 2015
Review: Needs Fixing
So much better, really close now. A few small things need to be fixed still:
1) Can we change the toolbar icon on the photo view in selection mode as the current ones are a little confusing. I think if the photo is not selected we should show an unchecked box and if it is selected we should show a checked box. What do you think? The cancel looking button was a little confusing.
2) When in picking mode and we open a photo, the header has a back button with "Events" in the title. It should have a back button with "Select" in the title as it does when you are in regular selection mode in the app (not via the picker).
3) In selection mode when you open a picture and then select it from there, then press the back button, can we autoscroll to that picture in the Events view to confirm for the user that it was in fact selected? If this is not possible it's ok, just checking.
4) Fullscreen mode not working correctly for Albums view (works great for other modes). When you open an album by clicking on it, it should open in fullscreen mode and function the same way as opening a picture from Events or Photos view. Currently it's not fullscreen when you open an album or even when you click again on the picture in the album. I think it should be fullscreen like the others even when the header visible, until you return to the main Albums view.
--
https://code.launchpad.net/~artmello/gallery-app/gallery-app-fix_1416043/+merge/248590
Your team Ubuntu Phablet Team is subscribed to branch lp:gallery-app.
More information about the Ubuntu-reviews
mailing list