[Merge] lp:~gang65/webbrowser-app/webbrowser-app-keyboard-shortcuts into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Wed Feb 11 09:24:17 UTC 2015
Thanks for your work on this Bartosz! I haven’t had time to do a full review yet, but here are a few comments already, in no particular order:
- The changes to equality operators are unrelated, can you please revert them?
- When closing the current tab (Ctrl+W), the next tab will automatically be open. However the tab should be explicitly closed, see how it’s done there: http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/app/webbrowser/TabsView.qml#L66
- For navigation between tabs: the tabs model is designed so that the current tab is always the first one, so you can’t really navigate linearly between tabs.
- Ctrl+D should check whether the current tab is already bookmarked, and if so remove the bookmark.
- Calls to currentWebview.go[Back|Forward] should be guarded by checks on the value of currentWebview.canGo[Back|Forward].
--
https://code.launchpad.net/~gang65/webbrowser-app/webbrowser-app-keyboard-shortcuts/+merge/249134
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~gang65/webbrowser-app/webbrowser-app-keyboard-shortcuts into lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list