[Merge] lp:~mir-team/qtubuntu/port-to-mirclient into lp:qtubuntu

Albert Astals Cid albert.astals at canonical.com
Wed Feb 11 10:43:02 UTC 2015


Review: Needs Information

	- if (ubuntuEvent->window->window() == nullptr) {
	+ if (ubuntuEvent->window == nullptr) {

Should the second one be 

  if (ubuntuEvent->window == nullptr || ubuntuEvent->window->window() == nullptr) {

To also cover what the previous check was doing?
-- 
https://code.launchpad.net/~mir-team/qtubuntu/port-to-mirclient/+merge/245164
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list