[Merge] lp:~gang65/webbrowser-app/webbrowser-app-keyboard-shortcuts into lp:webbrowser-app

Bartosz Kosiorek gang65 at poczta.onet.pl
Thu Feb 12 07:45:45 UTC 2015


Review: Needs Information

Thanks Olivier for review.

I would like to ask it change:
	-    beginMoveRows(QModelIndex(), index, index, QModelIndex(), 0);
127	+    beginMoveRows(QModelIndex(), index, m_tabs.count(), QModelIndex(), 0);

is ok for you.


Previously if you have tabs: "1 2 3 4" 
and setCurrent to "2"
you will receive "2 1 3 4"

After my implementation the order of tabs are preserved: "2 3 4 1" 


-- 
https://code.launchpad.net/~gang65/webbrowser-app/webbrowser-app-keyboard-shortcuts/+merge/249134
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list