[Merge] lp:~rpadovani/webbrowser-app/newTabRefactoring into lp:webbrowser-app

Riccardo Padovani riccardo at rpadovani.com
Sat Jan 24 12:22:27 UTC 2015


Riccardo Padovani has proposed merging lp:~rpadovani/webbrowser-app/newTabRefactoring into lp:webbrowser-app.

Commit message:
Improved new tab

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1351157 in webbrowser-app: "[browser] Update visual design of the new tab page"
  https://bugs.launchpad.net/webbrowser-app/+bug/1351157
  Bug #1389605 in webbrowser-app: "Bookmarks section header in new tab view not updated when a bookmark is added/removed"
  https://bugs.launchpad.net/webbrowser-app/+bug/1389605

For more details, see:
https://code.launchpad.net/~rpadovani/webbrowser-app/newTabRefactoring/+merge/247498

## WIP ##

Working on the new tab to fix all bugs and to enable portrait mode

# Known bugs
- When there are no bookmarks and a new one is added the delegate isn't show
- See more / less button isn't themed accordingly to UX specs

# Missing features 
- Portrait mode 

# Fixed bugs
- the "see more" / "see less" actions for bookmarks should be in the section header
- Bookmarks section header in new tab view not updated when a bookmark is added/removed
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~rpadovani/webbrowser-app/newTabRefactoring into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 6194 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150124/f3d40a19/attachment.diff>


More information about the Ubuntu-reviews mailing list