[Merge] lp:~rpadovani/webbrowser-app/fixBookmarkDesign into lp:webbrowser-app
Riccardo Padovani
riccardo at rpadovani.com
Wed Jan 28 18:47:37 UTC 2015
> This looks much better now. A bunch of additional minor remarks:
>
> - When in multi-selection mode, the checkbox is shifted a bit to the right
> (between 0.5 and 1 GU), and is not aligned with the section header
Wow, I didn't notice this! I spend some time to understand the difference, but I fixed it now
> - According to the visual spec, the background of the toolbar seems to be
> white
Fixed
>
> - When in multi-selection mode, scrolling the list up makes it overlap with
> the toolbar. Can the toolbar be made to appear on top of the list?
Fixed
> - When an entry is selected, it’s highlighted, but it’s not in the visual
> spec
I fixed that, but there is a little color change, because you asked[0] a response when there user click on something, so there is a color change on mouseArea.pressed.
Atm, I don't have an idea to avoid this color change... Suggestions?
[0]https://code.launchpad.net/~rpadovani/webbrowser-app/1351167/+merge/238155/comments/585299
--
https://code.launchpad.net/~rpadovani/webbrowser-app/fixBookmarkDesign/+merge/247512
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list