[Merge] lp:~rpadovani/webbrowser-app/fixBookmarkDesign into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Thu Jan 29 09:07:15 UTC 2015
Ah, sorry for suggesting the use of ToolbarButton, it is apparently deprecated (or meant to be anyway, I don’t see any reference to it being obsolete in the online docs, but I clearly remember a conversation with the UITK folks in which they said it shouldn’t be used anymore).
I now remember that I wrote a custom ToolbarAction component (src/app/webbrowser/ToolbarAction.qml) which does exactly what you need, can you use that one instead, for consistency across the code base? When the UITK provides a component we can use, we’ll just remove the custom one.
See how to use it here: http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/app/webbrowser/HistoryView.qml#L285
--
https://code.launchpad.net/~rpadovani/webbrowser-app/fixBookmarkDesign/+merge/247512
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list