[Merge] lp:~abreu-alexandre/webbrowser-app/intent into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Thu Jan 29 22:07:48 UTC 2015


279	+            // Fallback to a noop
280	+            result = d->evaluate(
281	+                        IntentFilterPrivate::DEFAULT_PASS_THROUGH_FILTER
282	+                        , intentDescription).toVariant().toMap();

This looks like a rather complex (and expensive) way of transforming intentDescription into a QVariantMap.
What about getting rid of the IntentUriDescription struct altogether, to replace it everywhere with QVariantMap?
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/intent/+merge/247421
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list