[Merge] lp:~nikwen/webbrowser-app/open-in-new-background-tab into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Fri Jan 30 06:48:49 UTC 2015
That looks great now, thanks!
A couple of really minor comments:
- the return type of allowOpenInBackgroundTab() could be "const QString&" to avoid an unnecessary copy
- "anything else disables background tabs" is confusing, background tabs are not disabled, it’s just that the context menu option is not available. Can it be "anything else disables the option" instead?
--
https://code.launchpad.net/~nikwen/webbrowser-app/open-in-new-background-tab/+merge/245372
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list