[Merge] lp:~phablet-team/ofono/update-july-first into lp:~phablet-team/ofono/ubuntu

Tony Espy espy at canonical.com
Wed Jul 1 18:05:01 UTC 2015


Review: Needs Fixing

The code all looks good.  That said, the changelog needs some fixing ( see inline comments ).

Diff comments:

> === modified file 'debian/control'
> --- debian/changelog	2015-05-21 08:44:39 +0000
> +++ debian/changelog	2015-07-01 13:15:27 +0000
> @@ -1,3 +1,23 @@
> +ofono (1.12.bzr6900+15.04.20150701-0ubuntu1) UNRELEASED; urgency=medium
> +

The bzr version should be 6898 as this will be version of the merge when it lands in lp:~phablet-team/ofono/ubuntu.

> +  [Tony Espy]
> +  * test/rilmodem/sim: fix testing scripts for arale
> +  * test: reverse meaning of list-modems -p

This needs a reference to lp: #1457775.

> +

This needs a reference to lp: #1438715.

> +  [ Alfonso Sanchez-Beato ]
> +  * gril: cleanup traces
> +  * src/gprs.c: set preferred for the used IA APN
> +  * rilmodem, mtkmodem, plugins/ril.c, plugins/mtk.c: retry when a

This needs a reference to the lp: #1361864.

> +    context deactivation request has finished with an error
> +  * build, include, plugins/c-ares-dns-client.c, src/dns-client.c,

Just checking whether or not we added a public bug for this? If not, don't bother creating one at this point.  Just wanted to be sure...

> +    src/gprs.c: resolve MMS proxy/MMSC host name (LP: #1417976)
> +
> +  [ Ratchanan Srirattanamet ]
> +  * build, rilmodem, qcommsimmodem, plugins/ril.c,
> +    src/radio-settings.c: add multi-sim support for qcommsimmodem
> +
> + -- Alfonso Sanchez-Beato (email Canonical) <alfonso.sanchez-beato at canonical.com>  Wed, 01 Jul 2015 08:40:36 +0200
> +
>  ofono (1.12.bzr6896+15.04.20150521-0ubuntu1) vivid; urgency=medium
>  
>    [ Ratchanan Srirattanamet ]


-- 
https://code.launchpad.net/~phablet-team/ofono/update-july-first/+merge/263462
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ofono/ubuntu.



More information about the Ubuntu-reviews mailing list