[Merge] lp:~seb128/telephony-service/dont-unref-gvariant into lp:telephony-service/rtm-15.04

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Mon Jul 6 16:11:37 UTC 2015


Gustavo Pichorim Boiko has proposed merging lp:~seb128/telephony-service/dont-unref-gvariant into lp:telephony-service/rtm-15.04.

Commit message:
don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by calling messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue

Requested reviews:
  PS Jenkins bot (ps-jenkins): continuous-integration
  Tiago Salem Herrmann (tiagosh)
Related bugs:
  Bug #1427286 in telephony-service (Ubuntu): "g_variant_unref warning displayed when calling back after a missed call "
  https://bugs.launchpad.net/ubuntu/+source/telephony-service/+bug/1427286

For more details, see:
https://code.launchpad.net/~seb128/telephony-service/dont-unref-gvariant/+merge/263928

don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by calling messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue
-- 
Your team Ubuntu Phablet Team is subscribed to branch lp:telephony-service/rtm-15.04.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 406 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150706/fe7e6858/attachment.diff>


More information about the Ubuntu-reviews mailing list